Don't output body for json DELETE requests #650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #650 +/- ##
=======================================
Coverage 80.73% 80.73%
=======================================
Files 83 83
Lines 7349 7352 +3
=======================================
+ Hits 5933 5936 +3
Misses 1416 1416 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0xTim
approved these changes
Apr 16, 2025
| @@ -260,6 +261,8 @@ extension AWSHTTPRequest { | |||
| guard self.headers["content-type"].first == nil else { | |||
| return | |||
| } | |||
| // in theory we don't need this check as the check for an empty body should skip adding | |||
| // a header and a GET or HEAD request should have an empty body | |||
| guard self.method != .GET, self.method != .HEAD else { | |||
There was a problem hiding this comment.
Do we not want to check for DELTE here as well?
There was a problem hiding this comment.
I'm trying to add code that has the least effect. I can't trust there isn't a service that includes a body with a delete method. The code above basically removes the body if it is {}.
0xTim
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP DELETE methods should not include a body. We were only checking for GET and HEAD method requests previously. It wasn't an issue but AWS lambda is now returning a signing error because of this. So I've added a check for DELETE method in the serialisation of json bodies.
EDIT: Verified it fixes signing issue with deleting lambdas