-
Notifications
You must be signed in to change notification settings - Fork 106
fix(web): batch findMany queries fixes #360 #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
24601
wants to merge
1
commit into
sourcebot-dev:main
Choose a base branch
from
24601:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,87 @@ | ||
/** | ||
* Utility functions for batched Repo queries to handle large datasets efficiently | ||
* and prevent memory issues like "Failed to convert rust String into napi string" | ||
* | ||
* This is a workaround for the Prisma issue: https://github.com/prisma/prisma/issues/13864 | ||
* | ||
* The batch size can be configured via the DB_QUERY_BATCH_SIZE environment variable | ||
* or the dbQueryBatchSize setting in the configuration file. | ||
*/ | ||
|
||
import { Repo } from "@sourcebot/db"; | ||
import { prisma } from "@/prisma"; | ||
import { env } from "@/env.mjs"; | ||
|
||
const DEFAULT_BATCH_SIZE = env.DB_QUERY_BATCH_SIZE; | ||
|
||
/** | ||
* Fetches repos by IDs in batches to prevent memory issues | ||
* @param ids - Array of repo IDs to fetch | ||
* @param orgId - Organization ID to filter by | ||
* @param batchSize - Size of each batch (default: 500) | ||
* @returns Array of repos | ||
*/ | ||
export async function batchedFindReposByIds( | ||
ids: number[], | ||
orgId: number, | ||
batchSize: number = DEFAULT_BATCH_SIZE | ||
): Promise<Repo[]> { | ||
if (ids.length === 0) { | ||
return []; | ||
} | ||
|
||
const results: Repo[] = []; | ||
const totalBatches = Math.ceil(ids.length / batchSize); | ||
|
||
for (let i = 0; i < totalBatches; i++) { | ||
const startIndex = i * batchSize; | ||
const endIndex = Math.min(startIndex + batchSize, ids.length); | ||
const batchIds = ids.slice(startIndex, endIndex); | ||
|
||
const batchResults = await prisma.repo.findMany({ | ||
where: { | ||
id: { in: batchIds }, | ||
orgId, | ||
} | ||
}); | ||
results.push(...batchResults); | ||
} | ||
|
||
return results; | ||
} | ||
|
||
/** | ||
* Fetches repos by names in batches to prevent memory issues | ||
* @param names - Array of repo names to fetch | ||
* @param orgId - Organization ID to filter by | ||
* @param batchSize - Size of each batch (default: 500) | ||
* @returns Array of repos | ||
*/ | ||
export async function batchedFindReposByNames( | ||
names: string[], | ||
orgId: number, | ||
batchSize: number = DEFAULT_BATCH_SIZE | ||
): Promise<Repo[]> { | ||
if (names.length === 0) { | ||
return []; | ||
} | ||
|
||
const results: Repo[] = []; | ||
const totalBatches = Math.ceil(names.length / batchSize); | ||
|
||
for (let i = 0; i < totalBatches; i++) { | ||
const startIndex = i * batchSize; | ||
const endIndex = Math.min(startIndex + batchSize, names.length); | ||
const batchNames = names.slice(startIndex, endIndex); | ||
|
||
const batchResults = await prisma.repo.findMany({ | ||
where: { | ||
name: { in: batchNames }, | ||
orgId, | ||
} | ||
}); | ||
results.push(...batchResults); | ||
} | ||
|
||
return results; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid manual edits in auto-generated file.
This interface is marked as auto-generated; manual modifications will be overwritten. Confirm the schema generator or codegen configuration was updated to include
dbQueryBatchSize
so that this change persists.🤖 Prompt for AI Agents