Skip to content

Linter: create rule to remove properties that are not required #1898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Linter: create rule to remove properties that are not required #1898

wants to merge 1 commit into from

Conversation

Karan-Palan
Copy link
Contributor

No description provided.

@Karan-Palan
create rule to remove properties that are not required
7a897b7 
Signed-off-by: karan-palan <karanpalan007@gmail.com>
jviotti
jviotti requested changes Jul 28, 2025
View reviewed changes
Copy link
Member

@jviotti jviotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is a valid one. Let's discuss more in the call. The constraints properties add are not related to required. If you don't have the properties in required, you are still adding valid constraints, just that the properties are optional

@Karan-Palan
Copy link
Contributor Author

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jviotti jviotti jviotti requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Karan-Palan @jviotti