Linter: create rule to to add syntactical sugar when then is set to false #1918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: karan-palan <karanpalan007@gmail.com>
Signed-off-by: karan-palan <karanpalan007@gmail.com>
|
@jviotti , any comments? |
jviotti
reviewed
Aug 7, 2025
Signed-off-by: karan-palan <karanpalan007@gmail.com>
|
@jviotti , any comments? |
jviotti
reviewed
Aug 11, 2025
|
|
||
| const sourcemeta::core::JSON expected = sourcemeta::core::parse_json(R"JSON({ | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "not": false |
There was a problem hiding this comment.
@Karan-Palan As a note for you, this is a good idea for a new rule on another PR: negating a negative doesn't do anything. In this case, this line could be removed
jviotti
reviewed
Aug 11, 2025
jviotti
reviewed
Aug 11, 2025
jviotti
reviewed
Aug 11, 2025
Signed-off-by: karan-palan <karanpalan007@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1897 (comment)