-
Notifications
You must be signed in to change notification settings - Fork 198
feat: Add authentication to the endpoints #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pablotp
wants to merge
6
commits into
sparfenyuk:main
Choose a base branch
from
pablotp:add-authentication
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+437
−80
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
72fa239
feat: Add authentication to the endpoints
pablotp f4dd492
feat: add --log-level option (#102)
bfontaine 2f8f658
fix: Address PR feedback
pablotp a549438
Merge branch 'main' into add-authentication
pablotp 218da4f
fix: Address PR feedback v2
pablotp a83d87c
Merge branch 'main' into add-authentication
pablotp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| """Simple authentication middleware for MCP proxy.""" | ||
|
|
||
| import logging | ||
| from collections.abc import Awaitable, Callable | ||
|
|
||
| from starlette.applications import Starlette | ||
| from starlette.middleware.base import BaseHTTPMiddleware | ||
| from starlette.requests import Request | ||
| from starlette.responses import JSONResponse, Response | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class AuthMiddleware(BaseHTTPMiddleware): | ||
| """Simple API key authentication middleware.""" | ||
|
|
||
| def __init__(self, app: Starlette, api_key: str | None = None) -> None: | ||
| """Initialize middleware with optional API key.""" | ||
| super().__init__(app) | ||
| self.api_key = api_key | ||
|
|
||
| async def dispatch( | ||
| self, | ||
| request: Request, | ||
| call_next: Callable[[Request], Awaitable[Response]], | ||
| ) -> Response: | ||
| """Check API key for protected endpoints.""" | ||
| # Skip auth if no API key configured | ||
| if not self.api_key: | ||
| return await call_next(request) | ||
|
|
||
| # Allow OPTIONS (CORS preflight) and /status endpoint | ||
| if request.method == "OPTIONS" or request.url.path == "/status": | ||
| return await call_next(request) | ||
|
|
||
| # Check if path needs protection (/sse, /mcp, /messages, /servers/*/sse, /servers/*/mcp) | ||
| path = request.url.path | ||
| needs_auth = ( | ||
| path.startswith(("/sse", "/mcp", "/messages")) or "/sse" in path or "/mcp" in path | ||
| ) | ||
|
|
||
| if not needs_auth: | ||
| return await call_next(request) | ||
|
|
||
| # Check for API key in headers (case-insensitive) | ||
| api_key = request.headers.get("x-api-key", "") | ||
|
|
||
| if api_key != self.api_key: | ||
| logger.warning("Auth failed for %s %s", request.method, path) | ||
| return JSONResponse( | ||
| {"error": "Unauthorized"}, | ||
| status_code=401, | ||
| ) | ||
|
|
||
| return await call_next(request) | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The path protection logic is duplicated and could match unintended paths. For example,
/ssein path would match/something/sse/other. Consider using a more precise pattern matching approach or regex to avoid false positives.