Skip to content

[3.0] Last bunch of fixes for ISO #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 30, 2025
Merged

[3.0] Last bunch of fixes for ISO #1297

merged 4 commits into from
Oct 30, 2025

Conversation

@zvr
Copy link
Member

@zvr zvr commented Oct 30, 2025

Various small fixes, addressing (some of) the issues listed in #1235, #1270, and #1271.

@zvr zvr added this to the 3.0.2 milestone Oct 30, 2025
@zvr zvr requested review from bact and goneall October 30, 2025 22:05
@zvr
leave only Normative references, per spdx-spec#1235
94e7d6b 
Signed-off-by: Alexios Zavras (zvr) <github@zvr.gr>
@zvr
Fixes a capitalization error
1691240 
Signed-off-by: Alexios Zavras (zvr) <github@zvr.gr>
goneall
goneall approved these changes Oct 30, 2025
View reviewed changes
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goneall
Copy link
Member

goneall commented Oct 30, 2025

Not sure what the DCO check is failing.

I had this happen on a draft PR I just created and I KNOW I signed off.

I'll override and merge this PR - but it would be nice to figure out why the checks are failing.

@goneall
Copy link
Member

goneall commented Oct 30, 2025

Not sure what the DCO check is failing.

I had this happen on a draft PR I just created and I KNOW I signed off.

I'll override and merge this PR - but it would be nice to figure out why the checks are failing.

Actually - it looks like it is just pending, not failing. Hmmm - even more curious.

@goneall goneall merged commit dc1b288 into spdx:support/3.0 Oct 30, 2025
2 of 3 checks passed
@bact
Copy link
Collaborator

bact commented Oct 31, 2025

Not sure what the DCO check is failing.

I had this happen on a draft PR I just created and I KNOW I signed off.

I'll override and merge this PR - but it would be nice to figure out why the checks are failing.

From GitHub web interface, looks like the first two commits (9d85624 and f7bdc76) are not signed? The last two (94e7d6b and 1691240) are signed.

@zvr zvr deleted the iso-fixes branch October 31, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bact bact bact approved these changes

@goneall goneall goneall approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0.2

Development

Successfully merging this pull request may close these issues.

3 participants

@zvr @goneall @bact