Remove wasm-pkg-common as dependency #3166
Closed
+165
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
It looks like it hasn't been tested and is probably broken but that can probably be resolved relatively easily. |
itowlson
approved these changes
Jun 18, 2025
fibonacci1729
approved these changes
Jun 18, 2025
|
For |
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
rylev
force-pushed
the
remove-wasm-pkg-dep
branch
from
f53393d to
78c77f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3165
I'm not sure if this is the way we'd like to address this issue. It does involve copying a few definitions from
wasm-pkg-common, but perhaps that's easiest?