This repository was archived by the owner on Jan 17, 2019. It is now read-only.
Fix simple OCLint warnings #337
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
==========================================
+ Coverage 80.08% 80.16% +0.07%
==========================================
Files 84 84
Lines 4510 4496 -14
==========================================
- Hits 3612 3604 -8
+ Misses 898 892 -6
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCLint is another static analysis tool that focuses on reducing complexity, confusion, and redundant code. It has a ton of rules. This PR knocks out some of the simpler ones.
The tool also handles analyzing cyclomatic complexity and npath complexity, which could help identify places that could probably use a refactor or reduction in complexity.
Many of the rules are conventional but could also be useful (method length, line length, class length, etc.)