Skip to content

Skip registering all OTLP tracing related beans if tracing is disabled #46166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Skip registering all OTLP tracing related beans if tracing is disabled #46166

wants to merge 1 commit into from
+14 −2

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Jun 23, 2025

Before this commit, OtlpTracingProperties and OtlpTracingConnectionDetails are registered even if tracing is disabled.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 23, 2025
@quaff quaff marked this pull request as draft June 23, 2025 08:40
@quaff
Copy link
Contributor Author

quaff commented Jun 23, 2025

It applies to other tracing AutoConfigurations such as ZipkinAutoConfiguration, should I create separate PR or append commits in this PR?

@quaff quaff marked this pull request as ready for review June 26, 2025 09:15
@quaff
Skip registering all OTLP tracing related beans if tracing is disabled
213d068 
Before this commit, `OtlpTracingProperties` and `OtlpTracingConnectionDetails` are registered even if tracing is disabled.

Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
@mhalbritter
Copy link
Contributor

mhalbritter commented Aug 29, 2025 •
edited
Loading

It's intended that OtlpTracingProperties and OtlpTracingConnectionDetails are registered. The @ConditionalOnEnabledTracing is intended to shut off tracing export (it should really be named @ConditionalOnEnabledTracingExport or something like that), not all tracing related beans.

@mhalbritter mhalbritter added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quaff @mhalbritter @spring-projects-issues