Skip to content

Refine AspectJ plugin build phase config #3284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Refine AspectJ plugin build phase config #3284

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e28a9f
Move AspectJ Maven executions to default phases
kriegaex Dec 28, 2023
4ac9cb4
Code review: remove commented-out phases
kriegaex Dec 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions spring-data-jpa/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,11 @@
</configuration>
</plugin>

<!--
Attention: aspectj-maven-plugin MUST be declared AFTER maven-compiler-plugin, if they are both supposed to run
in the same default phases 'compile' and 'test-compile', but execution order is to be guaranteed. Then, you have
the convenience of being able to run e.g. 'mvn [clean] compile' instead of 'mvn [clean] process-classes'.
-->
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>aspectj-maven-plugin</artifactId>
Expand All @@ -374,14 +379,12 @@
<goals>
<goal>compile</goal>
</goals>
<phase>process-classes</phase>
</execution>
<execution>
<id>aspectj-test-compile</id>
<goals>
<goal>test-compile</goal>
</goals>
<phase>process-test-classes</phase>
</execution>
</executions>
<configuration>
Expand Down