Skip to content

Convert applicable methods in Scope to default methods #34757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

Convert applicable methods in Scope to default methods #34757

merged 1 commit into from
Jul 7, 2025

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Apr 15, 2025 •
edited by sbrannen
Loading

getConversationId and resolveContextualObject are candidates for being converted to default methods, not sure about registerDestructionCallback.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 15, 2025
@sbrannen sbrannen added the in: core Issues in core modules (aop, beans, core, context, expression) label Apr 15, 2025
@sbrannen sbrannen changed the title Mark applicable Scope's methods as default Convert applicable methods in Scope to default methods Apr 15, 2025
@sbrannen sbrannen requested a review from jhoeller April 15, 2025 09:21
@jhoeller
Copy link
Contributor

jhoeller commented Jul 7, 2025 •
edited by sbrannen
Loading

@quaff this seems sensible. Please try to rebase it onto current main since there seem to be some conflicts in the meantime.

@jhoeller jhoeller added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 7, 2025
@jhoeller jhoeller self-assigned this Jul 7, 2025
@jhoeller jhoeller added this to the 7.0.0-M7 milestone Jul 7, 2025
@quaff
Mark applicable Scope's methods as default
a3ddee2 
Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
@quaff
Copy link
Contributor Author

quaff commented Jul 7, 2025

@quaff this seems sensible. Olease try to rebase it onto current main since there seem to be some conflicts in the meantime.

Done.

@jhoeller jhoeller merged commit 410a9ce into spring-projects:main Jul 7, 2025
2 checks passed
jhoeller added a commit that referenced this pull request Jul 7, 2025
@jhoeller
Add additional javadoc notes on 7.0
9406e7e 
See gh-34709
See gh-34757
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhoeller jhoeller Awaiting requested review from jhoeller

Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
7.0.0-M7
Development

Successfully merging this pull request may close these issues.
4 participants
@quaff @jhoeller @sbrannen @spring-projects-issues