Allow any @Transactional propagation for @TransactionalEventListener with BEFORE_COMMIT phase #35150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussions in #30679 and #31414, validation was added to restrict
@TransactionalEventListener
to only use@Transactional(propagation = Propagation.REQUIRES_NEW)
or@Transactional(propagation = Propagation.NOT_SUPPORTED)
.However, this validation is unnecessary when the
@TransactionalEventListener
phase isBEFORE_COMMIT
(excluding propagationNEVER
). While removing the@Transactional
would solve the issue, this creates unnecessary friction when upgrading Spring versions.