Skip to content

Correct the default value of nestedTransactionAllowed in Javadoc #35212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Dockerel
Copy link

@Dockerel Dockerel commented Jul 17, 2025

Correct the default value of nestedTransactionAllowed in Javadoc

  • Changed the default value in the Javadoc from false to true
  • For smoother wording, replaced "though, since" to "but" and “use” with “disallow”

The Javadoc for JpaTransactionManager currently states that the nestedTransactionAllowed flag defaults to false. However, the default constructor has been setting this flag to true.

/**
* Create a new JpaTransactionManager instance.
* <p>An EntityManagerFactory has to be set to be able to use it.
* @see #setEntityManagerFactory
*/
public JpaTransactionManager() {
    setNestedTransactionAllowed(true);
}

This PR updates the documentation to align with the actual behavior, ensuring consistency between the code and its Javadoc.

Let me know if you have any concerns or suggestions for further improvement.
Thank you for your time and consideration!

Signed-off-by: Giheon Do <dgh0001@naver.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 17, 2025
@sbrannen sbrannen added in: data Issues in data modules (jdbc, orm, oxm, tx) type: documentation A documentation task labels Jul 17, 2025
@sbrannen sbrannen requested a review from jhoeller July 17, 2025 10:02
Signed-off-by: Giheon Do <dgh0001@naver.com>
@Dockerel Dockerel force-pushed the docs/jpa-nested-tx-default branch from 4e8967a to 9d28e45 Compare July 21, 2025 06:46
@Dockerel Dockerel changed the title Correct the default value of nestedTransactionAllowed in Javadoc Correct and clarify Javadoc default for nestedTransactionAllowed in JpaTransactionManager Jul 21, 2025
@Dockerel Dockerel changed the title Correct and clarify Javadoc default for nestedTransactionAllowed in JpaTransactionManager Correct the default value of nestedTransactionAllowed in Javadoc Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) status: waiting-for-triage An issue we've not yet triaged or decided on type: documentation A documentation task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants