Adapt to Reactor 3.8 JSpecify annotations #35501
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dariusz Jędrzejczyk <dariusz.jedrzejczyk@broadcom.com>
spring-projects-issues
added
the
status: waiting-for-triage
sdeleuze
added
type: task
chemicL
commented
Sep 18, 2025
spring-context/src/main/java/org/springframework/cache/interceptor/CacheAspectSupport.java
Show resolved
Hide resolved
sdeleuze
requested changes
Sep 23, 2025
There was a problem hiding this comment.
I think some of those Objects#requireNonNull invocation are related to uber/NullAway#1290 so I would recommend to revise the PR by using @SupressWarnings("NullAway") // see https://github.com/uber/NullAway/issues/1290 instead for such lambdas.
Signed-off-by: Dariusz Jędrzejczyk <dariusz.jedrzejczyk@broadcom.com>
|
We need to analyze each usage where there is a nullability mismatch, but it looks correct from a reactor-core POV, so you can follow-up with reactor-core 3.8.0-RC1 release and we will take this PR from there. Thanks for submitting it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reactor-core 3.8.0-SNAPSHOT includes the migration from JSR-305-based nullability annotations to JSpecify.
This change adapts the spring-framework codebase to the changes caused by better nullability markers.
@sdeleuze please review and if something needs to change on the reactor-core side, I'd be happy to incorporate those recommendations.