Provide programmatic alternative to @ConcurrencyLimit #35553
Closed
+228
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes spring-projectsgh-35460 Signed-off-by: Geonhu Park <parkgeonhu@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
parkgeonhu
force-pushed
the
feature/35460
branch
from
e940dc3 to
cc7dc95
Compare
sbrannen
added
the
in: core
|
This is a fine implementation, well adapted to our coding practices - good job there! However, please see #35460 (comment) - I went with a different approach for 7.0, baking this support into Thanks for the PR, in any case! |
jhoeller
added
status: superseded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a programmatic alternative to @ConcurrencyLimit.
I've structured this implementation similarly to RetryTemplate.
Closes gh-35460
As a side note, it might be worth exploring a design for ConcurrencyThrottleInterceptor that's similar to AbstractRetryInterceptor in the future. 😀
This is my first time contributing, so I'm very open to feedback. Please let me know what can be improved or what kind of tests you'd like to see added.