Handle nullable columns for databases using pointers #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some databases (e.g. clickhouse) is using pointer values to represent nullable values when querying from the database. The current logic to transform values to strings when querying data, does not handle this correctly. It will simply transform the pointer to a string, which results in the pointer address being printed. To handle this, the value reported from the sql driver will now tried to be extracted, if it is a pointer. This means the value of the pointer will then be transformed to a string, instead of the pointer directly. Additionally, some cases where this was causing issues in the clickhouse implementation have been fixed. Fixes sqls-server#151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some databases (e.g. clickhouse) is using pointer values to represent nullable values when querying from the database. The current logic to transform values to strings when querying data, does not handle this correctly. It will simply transform the pointer to a string, which results in the pointer address being printed.
To handle this, the value reported from the sql driver will now tried to be extracted, if it is a pointer. This means the value of the pointer will then be transformed to a string, instead of the pointer directly.
Additionally, some cases where this was causing issues in the clickhouse implementation have been fixed.
Fixes #151