Add meaningful exception handling, report errors #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive exception handling to the ServiceX DID finder library. It introduces a new error reporting mechanism and creates specific exception types for different failure scenarios.
- Introduces new custom exception types for specific DID finding failures
- Adds error reporting to ServiceX through a new
/errorendpoint - Updates the main DID finder task to catch exceptions and report them appropriately
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/servicex_did_finder_lib/exceptions.py | Defines new exception hierarchy with specific error types for DID finding failures |
| src/servicex_did_finder_lib/servicex_adaptor.py | Adds new put_fileset_error method and convenience put_file_add method |
| src/servicex_did_finder_lib/did_finder_app.py | Updates exception handling to catch and report errors via new error endpoint |
| src/servicex_did_finder_lib/communication.py | Updates type hint for UserDIDHandler return type |
| tests/servicex_did_finder_lib_tests/test_servicex_adaptor.py | Adds tests for the new error reporting functionality |
| tests/servicex_did_finder_lib_tests/test_did_finder_app.py | Updates tests to cover new exception handling behavior |
ponyisi
force-pushed
the
lookup_failure_information
branch
from
fd918ac to
3a40ce3
Compare
gordonwatts
approved these changes
Aug 5, 2025
| def put_fileset_error(self, summary): | ||
| success = False | ||
| attempts = 0 | ||
| while not success and attempts < MAX_RETRIES: |
There was a problem hiding this comment.
Should this be using a retry decorator instead?
There was a problem hiding this comment.
Yes but if prefer to do that coherently with the other function in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call a new ServiceX endpoint if the DID finder throws an exception. Provide some exceptions to cover use cases.