feat(native): Add toHaveProp #148
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suany0805
reviewed
Apr 3, 2025
| * @returns the assertion instance | ||
| */ | ||
| public toHaveProp(propName: string, value?: unknown): this { | ||
| const propValue: unknown = get(this.actual, `props.${propName}`, undefined); |
There was a problem hiding this comment.
just as for my understanding, why are we using uknown instead of undefined or any in here?
suany0805
reviewed
Apr 3, 2025
| const invertedErrorMessage = value === undefined | ||
| ? `Expected element ${this.toString()} NOT to have prop '${propName}'.` | ||
| : `Expected element ${this.toString()} NOT to have prop '${propName}' with value '${String(value)}'.`; | ||
|
|
There was a problem hiding this comment.
What do you think about adding to the error message something like: Verify the element properties?
lopenchi
force-pushed
the
feat/native-to-contain-element
branch
2 times, most recently
from
4194055 to
392d9c6
Compare
lopenchi
force-pushed
the
feat/native-to-contain-element
branch
from
560250d to
a560a05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the toHaveProp() matcher for React Native