Replace slog with zap for global logging #1459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvarun11
force-pushed
the
feat-383-2
branch
5 times, most recently
from
18da781 to
3873e01
Compare
* Switch from slog to uber-go/zap SugaredLogger for better performance * Add *w functions (Debugw, Infow, etc.) for structured key-value logging * Add DPanic and Fatal log levels with corresponding *f/*w variants * Maintain structured/unstructured log switching via UNSTRUCTURED_LOGS * Preserve debug flag integration for log level control * Use go-logr/zapr for NewLogr() Kubernetes logr.Logger compatibility
Co-authored-by: Radoslav Dimitrov <radoslav@stacklok.com>
Co-authored-by: Radoslav Dimitrov <radoslav@stacklok.com>
Co-authored-by: Radoslav Dimitrov <radoslav@stacklok.com>
Co-authored-by: Radoslav Dimitrov <radoslav@stacklok.com>
|
Thanks @rdimitrov! Will be monitoring now just to make sure everything is working as expected and just in case anything comes up, please feel free to ping me on Discord. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #383
Based on the feedback received in #1362, this PR:
UNSTRUCTURED_LOGSenv varIt also:
Optionally, we can consider updating the
logger.Initialize()toinit().