Skip to content

Conversation

VisruthSK
Copy link
Member

@VisruthSK VisruthSK commented Jun 13, 2025

  • Adopted new theme closer to main Stan webpage
  • GitHub Action builds and deploys site on releases
  • GHA also deploys latest version of site on pushes to master at mc-stan.org/loo/dev/*

@VisruthSK VisruthSK changed the title Reformat packagedown workflow Reformat pkgdown workflow Jun 13, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.76%. Comparing base (b4c12c3) to head (89bdf92).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #292   +/-   ##
=======================================
  Coverage   92.76%   92.76%           
=======================================
  Files          31       31           
  Lines        2986     2986           
=======================================
  Hits         2770     2770           
  Misses        216      216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@VisruthSK
Copy link
Member Author

On second though, if possible, it might make more sense to automatically build and deploy sites to https://dev.mc-stan.org/loo/ and setup another workflow to generate the site on releases which would get pushed to https://mc-stan.org/loo/.

@VisruthSK
Copy link
Member Author

VisruthSK commented Jun 13, 2025

on:
pull_request:
should be removed once the workflow is confirmed to work.

Obviated

@jgabry
Copy link
Member

jgabry commented Jun 13, 2025

On second though, if possible, it might make more sense to automatically build and deploy sites to https://dev.mc-stan.org/loo/ and setup another workflow to generate the site on releases which would get pushed to https://mc-stan.org/loo/.

Yeah I agree that it would be preferable to only publish the site on https://mc-stan.org/loo/ when we do a release. If we publish at the main URL on every commit to master then the website could advertise unreleased features that aren't available on CRAN yet.

@jgabry
Copy link
Member

jgabry commented Jun 13, 2025

I think this looks good. But the regenerated website pages that are part of this PR are for the development version of loo, not the released version. So if I merge this won't it update the website to the development version?

@VisruthSK
Copy link
Member Author

Right, I'll move files from the gh-pages branch into the docs folder then

@VisruthSK
Copy link
Member Author

https://github.com/stan-dev/loo/actions/runs/15627201098/job/44023603976

Looks like the vignettes get built too.

@VisruthSK
Copy link
Member Author

Updated _pkgdown.yml to link to Aki's CV page. Closes #294

@VisruthSK VisruthSK requested a review from jgabry June 23, 2025 19:05
@VisruthSK
Copy link
Member Author

Closes #208.

@VisruthSK
Copy link
Member Author

@jgabry this should build the site in the pages directory and doesn't add any website files to the main branch. I'm running the pkgdown action again but hopefully it passes and this can be merged.

testthat (>= 3.0)
VignetteBuilder:
knitr
Config/Needs/website: VisruthSK/pkgdownConfig
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you feel about moving the pkgdownConfig repository into the stan-dev organization (with you as its maintainer if you want)?

Copy link
Member Author

@VisruthSK VisruthSK Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! I had vaguely planned for this anyway. I'll transfer ownership and fix the config later today.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Let me know if you run into any issues transferring it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have permission to transfer the repository it seems--probably because I can't make repos under the org?

@jgabry
Copy link
Member

jgabry commented Oct 16, 2025

Cool thanks, I think this looks great. I put two questions in review comments

@jgabry
Copy link
Member

jgabry commented Oct 16, 2025

I think this is ready to go except for updating the config after transferring the repo.

Merge Aki's documentation updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants