-
-
Notifications
You must be signed in to change notification settings - Fork 36
Reformat pkgdown workflow #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #292 +/- ##
=======================================
Coverage 92.76% 92.76%
=======================================
Files 31 31
Lines 2986 2986
=======================================
Hits 2770 2770
Misses 216 216 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
On second though, if possible, it might make more sense to automatically build and deploy sites to https://dev.mc-stan.org/loo/ and setup another workflow to generate the site on releases which would get pushed to https://mc-stan.org/loo/. |
Obviated |
Yeah I agree that it would be preferable to only publish the site on https://mc-stan.org/loo/ when we do a release. If we publish at the main URL on every commit to master then the website could advertise unreleased features that aren't available on CRAN yet. |
I think this looks good. But the regenerated website pages that are part of this PR are for the development version of loo, not the released version. So if I merge this won't it update the website to the development version? |
Right, I'll move files from the gh-pages branch into the docs folder then |
https://github.com/stan-dev/loo/actions/runs/15627201098/job/44023603976 Looks like the vignettes get built too. |
Updated |
Comment out push trigger for main and master branches
Closes #208. |
Pulled in fix for NAs which was breaking vignettes
@jgabry this should build the site in the pages directory and doesn't add any website files to the main branch. I'm running the pkgdown action again but hopefully it passes and this can be merged. |
testthat (>= 3.0) | ||
VignetteBuilder: | ||
knitr | ||
Config/Needs/website: VisruthSK/pkgdownConfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would you feel about moving the pkgdownConfig repository into the stan-dev organization (with you as its maintainer if you want)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! I had vaguely planned for this anyway. I'll transfer ownership and fix the config later today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Let me know if you run into any issues transferring it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have permission to transfer the repository it seems--probably because I can't make repos under the org?
Cool thanks, I think this looks great. I put two questions in review comments |
I think this is ready to go except for updating the config after transferring the repo. |
Merge Aki's documentation updates
mc-stan.org/loo/dev/*