-
Notifications
You must be signed in to change notification settings - Fork 86
Converting the ERC721 exercise to Cairo V1. #26
base: main
Are you sure you want to change the base?
Conversation
Hey @robertkodra, Firstly, my apologies for the delay in responding to your PR; the lapse was entirely on my end. I will give priority to reviewing the conversion of this workshop. I've taken the time to review your work on transitioning the ERC721 to Cairo V1, and I must say, I'm genuinely impressed. You've shown a clear understanding of the task at hand and your work is in line with our prior discussions.
Once again, kudos on your fantastic work so far. I look forward to seeing your progress on the ERC721 workshop. |
Thanks @omarespejel for the review. I will try to submit a few updates this weekend and add the rest of the contract to it. I'll tag you once I make the changes. |
Thank you @robertkodra! Feel free to ask me whatever you need. Thanks! |
-fixed the bool_eq issue
This is the first commit to transition the ERC721 to Cairo V1.
I've divided the exercises into two parts. The first part is building your ERC721 from scratch. The second part is still WIP, which focuses on adding the exercises that are in the Cairo V0 repo, mainly creating features such as wings, legs, etc and the rest of the exercises.
Regarding Part 1 I've created the following:
user_slot
number from the Evaluator.transfer_from()
function transfer has bee implemented correctly.I've made the PR in draft as there are still things to work out on the first part.