Process shutdown, chronos version #7532
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebase of #7404 following the adoption of #7418. When using chronos to terminate the process, we run into various threading and cross-platform issues captured in status-im/nim-chronos#581, specially in `nimbus` which has a more complex threading picture.
siddarthkay
force-pushed
the
unstable
branch
2 times, most recently
from
6c84d01 to
b118196
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #7404 following the adoption of #7418.
When using chronos to terminate the process, we run into various threading and cross-platform issues captured in
status-im/nim-chronos#581, specially in
nimbuswhich has a more complex threading picture.Draft pending a resolution of the above issues which are fairly messy.