-
-
Notifications
You must be signed in to change notification settings - Fork 52
[CHORE] Update logging for automation_library MessageLog changes.
#51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sj-Si
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Performed self review of changes. Fixed any issues that I found along the way.
|
I will hold off on this until the next version is ready to be released. Just in case we need to refactor the project to use the log level wrappers again. |
|
Alright I am freezing additional changes for |
|
Had to merge master to this branch as there were too many changes made since. I will start refactoring to use the log level wrappers. |
One thing I noticed is in a few places the base |
Yup you are correct. Too verbose IIRC. |
|
As for the |
steve1316
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great in my test runs. LGTM!
I think I started with all caps for the tag for the aesthetics 4 years ago for some reason haha |
Brief
This PR updates all logging to use the updated
MessageLogfunctions in theautomation_library.This PR depends on Sj-Si:chore/message-log
Changes
The biggest change in this PR is in the
Gameobject, where we removed theprintToLogfunction. This forced all references togame.printToLog()to instead use theMessageLoglogging functions.This helps to decouple logging functionality so that individual components do not rely as much on having a reference to a
Gameobject stored at runtime.Please review the associated PR linked above for more detailed information on the changes to
MessageLog.Notes
I have not been able to perform a live test of these changes since I don't know how to run the app while using a different branch of the
automation_library.