Skip to content

(Closes #2561) Add support for allocatables in the HoistLocalArraysTrans #2893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

sergisiso
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 96.82540% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.89%. Comparing base (7ef4ec2) to head (d95917d).

Files with missing lines Patch % Lines
.../psyir/transformations/hoist_local_arrays_trans.py 96.82% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2893      +/-   ##
==========================================
- Coverage   99.89%   99.89%   -0.01%     
==========================================
  Files         362      362              
  Lines       51571    51616      +45     
==========================================
+ Hits        51519    51562      +43     
- Misses         52       54       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sergisiso
Copy link
Collaborator Author

sergisiso commented Feb 21, 2025

Integration test passed but the change was not applied almost anywhere because the arrays of interest have:
real(kind=wp), ...
but the transformation validation does:

if isinstance(sym.datatype.intrinsic, DataTypeSymbol):
    continue
if isinstance(sym.datatype.precision, DataSymbol):
    continue

I think we could refine this to check that this symbol is not local to the subroutine and the subroutine doesn't have wilcard imports.

@sergisiso sergisiso self-assigned this Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant