Minor improvments #253
Open
Minor improvments #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
khalford
commented
Oct 14, 2025
khalford
commented
- Updates to the container config for cAdvisor and ChatOps
- Fix logstash config path
- Remove volume facts from play
- Add missing role play into deploy.yml
Minor updates to container config including typos. Also, create 3 containers instead of one as we are running on the same host
Fixing logstash config path
We cannot rely on the OpenStack API to provide accurate information about where the device is mounted. This is due to a discrepancy between OpenStack and the OS of the VM. To work around this we will try the two most common devices, sdb and vdb. If both of these fail intervention will be required. A bonus to this is it removes the convoluted ansible fact solution previously used.
khalford
requested review from
a team,
RJaliliSTFC,
RWhiting78,
dev-0pz and
meoflynn
and removed request for
a team,
RJaliliSTFC and
meoflynn
RWhiting78
approved these changes
Oct 14, 2025
Comment on lines
45
to
+63
| - name: Start ChatOps container | ||
| community.docker.docker_container: | ||
| image: harbor.stfc.ac.uk/stfc-cloud/cloud-chatops:7.0.0 | ||
| name: chatops | ||
| image: "{{ chatops_image }}" | ||
| name: "chatops-{{ count }}" | ||
| pull: always | ||
| state: started | ||
| restart: true | ||
| ports: | ||
| - "3000:3000" | ||
| - "{{ item }}:3000" | ||
| volumes: | ||
| - /etc/chatops/config.yml:/usr/src/app/cloud_chatops/config/config.yml | ||
| - /etc/chatops/secrets.yml:/usr/src/app/cloud_chatops/secrets/secrets.yml | ||
| network_mode: host | ||
| - /etc/chatops/config.yml:/usr/src/app/config.yml | ||
| - /etc/chatops/secrets.yml:/usr/src/app/secrets.yml | ||
| restart_policy: "always" | ||
| loop: | ||
| - 3030 | ||
| - 3031 | ||
| - 3032 | ||
| loop_control: | ||
| index_var: count |
There was a problem hiding this comment.
How come you are creating 3 containers here with a unique name? Is this so that ChatOps with have high availability?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.