POC of typed extension views for arbitrary list of extensions. #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brabeji
commented
Sep 1, 2024
| @@ -44,4 +47,10 @@ export interface JsonNode<View = unknown> extends Identifiable { | |||
| api: undefined | unknown; // JsonNodeApi<this>; | |||
| } | |||
|
|
|||
| export type JsonNodeView<N> = N extends JsonNode<infer V> ? V : {[K in keyof N]: JsonNodeView<N[K]>}; | |||
| export type JsonNodeView<N> = N extends ExtNode<any, infer V> | |||
There was a problem hiding this comment.
Not sure if the first branch is necessary
brabeji
force-pushed
the
dynamic-ext-view-types
branch
from
8ae7ac0 to
e6015e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent some time on this, so I'm sharing it as a short draft. LMK if this is the right direction for the API.
json-joy is impressive stuff, thank you @streamich