fix 'center_shift=nan' bug and add a dependency 'numba' for installing from source #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear,
When running the code, I also encountered the "center_shift=nan" bug (which was also reported in issue #3). I would like to thank @GenjiB for identifying the issue: "If a cluster_center is an outlier, there are no neighbor points to calculate the mean point. To calculate the mean of none points results in Nan."
@GenjiB also proposed a solution that worked for me. To facilitate the use of this solution by others, we have modified the source code accordingly. Additionally, we found that numbda needs to be installed before running the code from source, and we have added a corresponding prompt in the ReadMe file.
Best regards,
Nianzu Yang