[JavaScript] Fix nested template strings #4318
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit... 1. introduces JavaScript (Plain) and TypeScript (Plain) without syntax highlighting in tagged template strings. 2. replaces `embed` directives by `set` and include all syntaxes used for highlighting tagged template strings, to prevent nested interpolations with template strings prematurely terminate the outer template string. 3. Nested template strings don't highlight any syntax to keep syntax cache size in sane limits. 4. JSX and TSX use "Plain" syntax without syntax highlighted template strings. Attempting to base them onto normal JS and TS raises errors about not all base syntaxes using same base.
|
I wouldn’t say it only goes from 4.2 to 5.4. That’s 25% or so increase in size. Relatively large |
|
Not limiting to "plain" syntaxes in nested templates it would go from 4.2 to 12MB, which the "only" was compared with. |
jrappen
approved these changes
Jun 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4220
This PR...
introduces JavaScript (Plain), TypeScript (Plain), JSX (Plain) and TSX (Plain) without syntax highlighted template strings as possible base syntax for template languages which don't need them or would fail loading due to complexity otherwise.
replaces
embeddirectives bysetand includes all syntaxes used for highlighting template strings, to prevent them being prematurely terminated by interpolations with nested template strings.Nested template strings don't highlight any syntax to keep syntax cache size in sane limits.
Note:
Compiled syntax cache of each language grows from about 170kB to 1.2MB also causing all template languages which make use of it to grow. I didn't hit any limits yet and Python is also 2.5MB now with new SQL syntax being included a couple of times. The overall size of all compiled languages together grows from 4.2MB to 5.4MB, only. So maybe it is safe enough for production.