✨(frontend) make delete buttons nvda-accessible; add close to title a… #1281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovgodd
force-pushed
the
fix/nvda-close-button
branch
from
9a13513 to
8edc540
Compare
Ovgodd
force-pushed
the
fix/nvda-close-button
branch
2 times, most recently
from
cacc2df to
076e76f
Compare
AntoLC
reviewed
Aug 12, 2025
| @@ -72,6 +72,7 @@ test.describe('Home page', () => { | |||
| await page.waitForLoadState('domcontentloaded'); | |||
|
|
|||
| // Wait a bit more for the responsive store to be initialized | |||
| // eslint-disable-next-line playwright/no-wait-for-timeout | |||
yes this is a good idea ! and create a specific modal folder too. |
Ovgodd
force-pushed
the
fix/nvda-close-button
branch
from
ba5ff2d to
f3c690d
Compare
|
Size Change: -834 B (-0.02%) Total Size: 3.65 MB
|
AntoLC
approved these changes
Sep 5, 2025
src/frontend/apps/impress/src/components/modal/ButtonCloseModal.tsx
Outdated
Show resolved
Hide resolved
Ovgodd
force-pushed
the
fix/nvda-close-button
branch
3 times, most recently
from
abf75ae to
c6f5889
Compare
add aria-labels and include close button in title prop so NVDA announces actions Signed-off-by: Cyril <c.gromoff@gmail.com>
Ovgodd
force-pushed
the
fix/nvda-close-button
branch
from
c6f5889 to
084d0c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Improve NVDA accessibility by replacing non-labeled modal close buttons from cunningham-react with custom buttons in the title prop and explicit aria-labels
Proposal