You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internally at Google, we have some company-wide conformance tests that ensure that all errors that are thrown, are subclasses of Error.
To ensure this, I adjusted the createNeverThrowError func to return a new NeverThrowError class, which both extends Error and overwrites the object's prototype to ensure that it is Error.
createNeverThrowError feels like an internal detail of the library and is only used in some fringe boundary cases. I added a quick test in a spot that felt the most obvious. Suggestions on alternatives are welcome!
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
I'm going to yield to the maintainers on whether or not this is a version bump. LMK if you'd like me to click the button :)
richieforeman
changed the title
Ensure that createNeverThrowError throws an Error that is an instance of Error class.
Ensure that createNeverThrowError returns an Error that is an instance of Error class.
Apr 28, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
richieforeman
changed the title
Internally at Google, we have some company-wide conformance tests that ensure that all errors that are thrown, are subclasses of
Error.To ensure this, I adjusted the
createNeverThrowErrorfunc to return a newNeverThrowErrorclass, which both extendsErrorand overwrites the object's prototype to ensure that it isError.This allows for:
createNeverThrowErrorfeels like an internal detail of the library and is only used in some fringe boundary cases. I added a quick test in a spot that felt the most obvious. Suggestions on alternatives are welcome!