doc: enhancement proposal for supporing Redfish #2245
Conversation
sthaha
force-pushed
the
feat-redfish
branch
4 times, most recently
from
b206076 to
f52528c
Compare
|
Hi @sthaha , But there is also other one in the Redfish specification. Please check this: https://www.dmtf.org/sites/default/files/standards/documents/DSP0268_2024.4.html#environmentmetrics-132 |
Hi @aharivel! I believe gofish library solves this problem that you pointed out but we should test this of course ... see kepler implementation in progress #2263 E.g ... https://github.com/stmcginnis/gofish/blob/v0.15.0/redfish/chassis.go#L443-L478 I think for each vendor, gofish creates and endpoint specific to the vendor
I believe kepler code should uniformly work across all vendors supported by gofish. Also .. any fix to redfish support should be contributed to gofish library. |
Add enhancement proposal document outlining the design and implementation approach for integrating Redfish power measurement capabilities into Kepler. Signed-off-by: Sunil Thaha <sthaha@redhat.com>
| kepler_node_platform_joules_total{source="redfish",node_name="worker-1"} 123456.789 | ||
|
|
||
| # Existing CPU metrics unchanged | ||
| kepler_node_cpu_watts{zone="package",node_name="worker-1"} 125.2 |
There was a problem hiding this comment.
should we add a source label in existing cpu_watts metrics? set the label according to the cpu power source. currently source=rapl will be there.
|
|
||
| ## Node Identification | ||
|
|
||
| Nodes identified via `--platform.node-id` flag or `platform.nodeID` config, |
There was a problem hiding this comment.
| Nodes identified via `--platform.node-id` flag or `platform.nodeID` config, | |
| Nodes identified via `--platform.node-id` flag or `nodes.nodeID` config, |
| worker-1: bmc-1 | ||
| worker-2: bmc-2 |
There was a problem hiding this comment.
how are the nodes identified here? with kubernetes node name? or whatever is passed to the flag platform.node-id by the operator?
| ```yaml | ||
| nodes: | ||
| worker-1: bmc-1 | ||
| worker-2: bmc-2 |
There was a problem hiding this comment.
can the bmc IP be auto discovered? the Redfish/BMC appears as a virtual nic. and BMC may appear in /etc/hosts
| bmc-1: | ||
| endpoint: "https://192.168.1.100" | ||
| username: "admin" | ||
| password: "secret" | ||
| insecure: true # TLS verification |
There was a problem hiding this comment.
api calls for redfish require a ChassisId , do we need config item for that?
|
|
||
| - Credentials in Kubernetes secrets or secure files (mode 0600) | ||
| - No credential logging | ||
| - Require explicit opt-in via configuration |
There was a problem hiding this comment.
pls add a small section for kepler config changes too
Addresses #2078