-
Notifications
You must be signed in to change notification settings - Fork 213
feat(Dockerfile): use FROM scratch container #2255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Arthur Exaltação <arthur.exaltacao@chainguard.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general it's LGTM.
If no further comments, I will approve the the CI to run tests by end of this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel there is value having a minimal set of tools available when debugging issues in kubernetes env. Moreover, ubi images are being updated almost everyday as CVEs are fixed. I am not is support of changing the base image to scratch.
cc: @vprashar2929 , @vimalk78 thoughts ?
we can use publicly available |
do we need curl after reboot? |
@vimalk78 , I searched among our code base https://github.com/search?q=repo%3Asustainable-computing-io%2Fkepler%20curl&type=code it seems we don't need curl. Please further investigate with tooling usage as curl and others. if we don't need curl, it's better for us to use a small base image for less CVE scope. |
The need for minimal tools is to debug failures in production. Especially n/w related issues. |
in this case, please add the steps in details in kepler repo document, and let's keep this PR open for now.(as TBD for me) |
We seem to be using an ubi9 container instead of a smaller base, this leads to having a lot more vulnerabilities without much need considering kepler is technically the only thing you need to run it like that. If the base container is really necessary, I would instead recommend using alpine or debian-slim as a base considering how many vulnerabilities get reported by grype with the current image
UBI9 image
FROM scratch image