feat(device): implement MSR fallback for CPU power meter #2273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces enhancement proposal for adding MSR (Model Specific Register) support as a fallback mechanism when Intel RAPL powercap sysfs interface is unavailable. This improves Kepler's deployment flexibility in environments with restricted powercap access. The proposal includes: - Architecture design using powerReader abstraction - Security considerations for MSR access (PLATYPUS mitigation) - Phased implementation plan with backward compatibility - Configuration for opt-in MSR fallback behavior Signed-off-by: Sunil Thaha <sthaha@redhat.com>
github-actions
bot
added
feat
|
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2273 +/- ##
==========================================
- Coverage 92.27% 88.78% -3.50%
==========================================
Files 39 42 +3
Lines 4142 4501 +359
==========================================
+ Hits 3822 3996 +174
- Misses 257 410 +153
- Partials 63 95 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This commit implements EP-002 MSR fallback power meter enhancement proposal. Add MSR (Model Specific Register) support as fallback when powercap interface is unavailable. This enhancement improves Kepler's compatibility across different systems and kernel configurations. Key changes: - Add MSR reader implementation with Intel RAPL register support - Create raplReader interface abstracting powercap and MSR backends - Extract existing powercap logic into dedicated reader component - Enhance RAPL power meter with automatic fallback detection - Add MSR configuration with security-conscious opt-in defaults - Implement comprehensive test coverage with mock MSR data The MSR fallback is disabled by default due to PLATYPUS attack vectors (CVE-2020-8694/8695) and must be explicitly enabled via configuration. When enabled, the system automatically falls back to MSR if powercap is unavailable, maintaining transparent operation. Signed-off-by: Sunil Thaha <sthaha@redhat.com>
sthaha
force-pushed
the
feat-rapl-msr-impl
branch
from
707625d to
7f7308a
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements EP-002 MSR fallback power meter enhancement proposal.
Add MSR (Model Specific Register) support as fallback when powercap interface
is unavailable. This enhancement improves Kepler's compatibility across
different systems and kernel configurations.
Key changes:
The MSR fallback is disabled by default due to PLATYPUS attack vectors
(CVE-2020-8694/8695) and must be explicitly enabled via configuration.
When enabled, the system automatically falls back to MSR if powercap
is unavailable, maintaining transparent operation.