fix: resolve aliases before transpiling for rewriteRelativeImportExtensions
#14673
+49
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This swaps the order of TypeScript transpilation and alias resolution in
@sveltejs/package
to address the problem described in #13044. TypeScript sees aliases like$lib/
as bare imports and does not applyrewriteRelativeImportExtensions
, and resolving aliases first seems like the correct fix. For more see microsoft/TypeScript#61991 (comment)Before, this code:
Generates this despite
rewriteRelativeImportExtensions: true
:Now it's correctly:
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits