Skip to content

Conversation

ryanatkn
Copy link
Contributor

@ryanatkn ryanatkn commented Oct 9, 2025

This swaps the order of TypeScript transpilation and alias resolution in @sveltejs/package to address the problem described in #13044. TypeScript sees aliases like $lib/ as bare imports and does not apply rewriteRelativeImportExtensions, and resolving aliases first seems like the correct fix. For more see microsoft/TypeScript#61991 (comment)

Before, this code:

import { helper } from '$lib/helper.ts';

Generates this despite rewriteRelativeImportExtensions: true:

import { helper } from './helper.ts';

Now it's correctly:

import { helper } from "./helper.js";

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Oct 9, 2025

🦋 Changeset detected

Latest commit: d533e18

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/package Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

@ryanatkn ryanatkn changed the title fix: resolve aliases before transpiling for aliased extension rewrites fix: resolve aliases before transpiling for rewriteRelativeImportExtensions Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant