Skip to content

Conversation

sillvva
Copy link

@sillvva sillvva commented Oct 10, 2025

fixes #14687

This ensures form.fields.allIssues() always exists, even if T in RemoteFormFields<T> is unknown or otherwise indefinitely recursive.

Example:

type Test1 = RemoteFormFields<unknown>["allIssues"]; // ✅ after, ❌ before 
type Test2 = RemoteFormFields<unknown>["foo"]["as"]; // ✅ after, ✅ before 

Nested unknown properties will still be treated as leaves, aka RemoteFormField. For example, if form.fields.nested is of type unknown, it will be considered a leaf and have the as method.

Example:

type Nested = { foo: { bar: string; baz: unknown; } };
type Test3 = RemoteFormFields<Nested>["allIssues"]; // ✅ after, ✅ before
type Test4 = RemoteFormFields<Nested>["foo"]["allIssues"]; // ✅ after, ✅ before
type Test5 = RemoteFormFields<Nested>["foo"]["bar"]["as"]; // ✅ after, ✅ before
type Test6 = RemoteFormFields<Nested>["foo"]["baz"]["as"]; // ✅ after, ✅ before

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Oct 10, 2025

🦋 Changeset detected

Latest commit: f8425cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

@sillvva sillvva changed the title fix RecursiveFormFields type for recursive or unknown schemas fix: fix RecursiveFormFields type for recursive or unknown schemas Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RecursiveFormFields type is missing the definition for the allIssues method

1 participant