Skip to content

Conversation

tolu
Copy link

@tolu tolu commented Oct 12, 2025

Closes #14681

sorry for not waiting on a discussion or go ahead in the issue I created, but this felt like a bug and such a straight forward fix that I hope it was ok to just create the PR 🙏

Problem

setHeaders throws when attempting to add a second server-timing since the key already exist in the internal Map headers. server-timing should use append rather than set since many values are allowed.

Fix

Appends value of header server-timing if a key already exists in headers when using setHeaders. The value is concatenated in the same way that calling Headers: append() does: with a comma and a space (, ).


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Oct 12, 2025

🦋 Changeset detected

Latest commit: f67fb87

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: setHeaders throws when adding second Server-Timing-header (should be appended)

1 participant