-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
chore: update svelte-ecosystem-ci trigger #16315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
set to draft because we have to update repo secrets to match this change |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think we need the probing, the chance that you run the CI and it's not on pkg.new yet is close to zero.
Who can to update the secrets and where exactly?
secret howto is here https://github.com/vitejs/vite-ecosystem-ci/blob/main/docs/pr-comment-setup.md there may be older secrets that can be deleted then, it requires admin access to sveltejs/svelte repo and sveltejs/svelte-ecosystem-ci |
The linked secrets already exist in Svelte and ecosystem-ci - not sure what needs updating? |
previously it was using a third party action to connect the repos through that app secret, i think we need to create a new one for the first party action it uses now |
@sapphi-red confirmed it can be reused, so just merging after the update in svelte-ecosystem-ci is fine. |
compared to vite's trigger, this does not probe pr.pkg.new as we publish all PR commits there anyways.
is this ok or do we have to port that over too?
see https://github.com/vitejs/vite/blob/main/.github/workflows/ecosystem-ci-trigger.yml
and https://github.com/vitejs/vite/blob/38bb268cde15541321f36016e77d61eecb707298/.github/workflows/preview-release.yml#L22
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint