feat(svix-server): server healthchecks #1949
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As discussed in the community slack, the server lacks of healthcheck which is easily available for instrumentalisation (docker-compose, kubernetes, etc)
Solution
I'm personally inclined not to have a command in the svix-server binary, mostly because it would not self-introspect a running server but rather "just fetch the healthcheck endpoint", therefore adding curl to the docker image seems lighter and less invasive imho.
I've implemented both solutions:
HEAD /v1/health
request and returnsOk()
on 200 (error otherwise)Note