perf: flatten sourceMap to improve memory usage #4964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
char0n
reviewed
Jun 27, 2025
| @@ -212,18 +211,26 @@ class YamlAstVisitor { | |||
| return null; | |||
| } | |||
|
|
|||
| /* eslint-disable no-param-reassign */ | |||
| private maybeAddSourceMap(node: unknown, element: Element): void { | |||
There was a problem hiding this comment.
node: unknown - type with extends Node from apidom-ast package
char0n
reviewed
Jun 27, 2025
| @@ -220,7 +206,14 @@ export const isPrimitiveElement: ElementPredicate<PrimitiveElement> = ( | |||
| * @public | |||
| */ | |||
| export const hasElementSourceMap = <T extends Element>(element: T): boolean => { | |||
| return isSourceMapElement(element.meta.get('sourceMap')); | |||
| return ( | |||
There was a problem hiding this comment.
Probably using a Number.isInteger is warranted here.
There was a problem hiding this comment.
And let's make this function safe - meaning it never throws. We can use isElement and only continue after truthy assertion.
char0n
reviewed
Jun 27, 2025
| const sourceMapElement = element.getMetaProperty('sourceMap'); | ||
| const charStart = toValue(sourceMapElement.positionStart.get(2)); | ||
| const charEnd = toValue(sourceMapElement.positionEnd.get(2)); | ||
| const charStart = element.startIndex; |
There was a problem hiding this comment.
Align naming with new sourcemap fields.
char0n
reviewed
Jun 27, 2025
| } | ||
| } | ||
| if (hasElementSourceMap(from)) { | ||
| to.startPositionRow = from.startPositionRow; |
There was a problem hiding this comment.
assignSourceMap(to, from)
->
to.startPositionRow = from.startPositionRow
...
Possibly making it safe later. No parameter destricturing as it might be used in syntactic analysis or refracting, so we want to keep it fast.
char0n
reviewed
Jun 27, 2025
| return new JsonDocument({ | ||
| children: node.children, | ||
| position, | ||
| startPositionRow: node.startPositionRow, |
There was a problem hiding this comment.
return new JsonDocument(
assignSourceMap({
children: node.children,
isMissing: node.isMissing,
}, node)
);
char0n
approved these changes
Jun 27, 2025
lukaszzazulak
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.