Add an init() that match the APIGatewayResponse #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natanrolnik
approved these changes
Aug 6, 2025
natanrolnik
added a commit
to natanrolnik/swift-aws-lambda-events
that referenced
this pull request
Aug 6, 2025
sebsto
pushed a commit
that referenced
this pull request
Aug 7, 2025
In a previous PR (#91), a new init with a different parameters order was added, marking the previous one was deprecated. The problem is that the compiler doesn't know which one to choose when omitting the final parameters. This PR fixes it by marking the deprecated init with `@_disfavoredOverload`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an
init()toFunctionURLResponseto match the signature ofAPIGatewayv2ResponseMotivation:
APIGAtewayV2ResponseandFunctionURLResponseshare teh same structure, although we provided two different signatures for the initializers. This prevent writing common code to handle both responses.Modifications:
init(0that has the same signature as the init from APIGatewayV2responseResult:
Two init() functions on FunctionURLResponse