-
Notifications
You must be signed in to change notification settings - Fork 116
Remove dependency on DispatchWallTime (fix #384) #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e7eed85
remove dependency on DispatchWallTime (fix #384)
sebsto 0903737
Remove distant future and use hardcoded max lambda execution time in …
sebsto bf738fe
change comment
sebsto 70c0af1
Simplify deadlineDate
sebsto 730230a
use a lambda clock based on unix epoch time
sebsto 8de2212
remove import dispatch
sebsto bf2f10d
fix docc
sebsto e319ff4
import correct lib based on platform
sebsto 5fb71d8
Merge branch 'main' into sebsto/DispatchWallTime
sebsto 02a54df
Merge branch 'main' into sebsto/DispatchWallTime
sebsto d699f36
fix remianing time
sebsto 62ae211
add unit test for LambdaClock.now
sebsto c98caa3
Merge branch 'main' into sebsto/DispatchWallTime
sebsto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,7 +25,7 @@ public struct LambdaContext: CustomDebugStringConvertible, Sendable { | |
let requestID: String | ||
let traceID: String | ||
let invokedFunctionARN: String | ||
let deadline: DispatchWallTime | ||
let deadline: Duration | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You need to remove the Dispatch import at the top of the file |
||
let cognitoIdentity: String? | ||
let clientContext: String? | ||
let logger: Logger | ||
|
@@ -34,7 +34,7 @@ public struct LambdaContext: CustomDebugStringConvertible, Sendable { | |
requestID: String, | ||
traceID: String, | ||
invokedFunctionARN: String, | ||
deadline: DispatchWallTime, | ||
deadline: Duration, | ||
cognitoIdentity: String?, | ||
clientContext: String?, | ||
logger: Logger | ||
|
@@ -67,7 +67,7 @@ public struct LambdaContext: CustomDebugStringConvertible, Sendable { | |
} | ||
|
||
/// The timestamp that the function times out. | ||
public var deadline: DispatchWallTime { | ||
public var deadline: Duration { | ||
self.storage.deadline | ||
} | ||
|
||
|
@@ -92,7 +92,7 @@ public struct LambdaContext: CustomDebugStringConvertible, Sendable { | |
requestID: String, | ||
traceID: String, | ||
invokedFunctionARN: String, | ||
deadline: DispatchWallTime, | ||
deadline: Duration, | ||
cognitoIdentity: String? = nil, | ||
clientContext: String? = nil, | ||
logger: Logger | ||
|
@@ -109,30 +109,30 @@ public struct LambdaContext: CustomDebugStringConvertible, Sendable { | |
} | ||
|
||
public func getRemainingTime() -> Duration { | ||
let deadline = self.deadline.millisSinceEpoch | ||
let now = DispatchWallTime.now().millisSinceEpoch | ||
let deadline = self.deadline | ||
let now = Duration.millisSinceEpoch | ||
|
||
let remaining = deadline - now | ||
return .milliseconds(remaining) | ||
return deadline - now | ||
} | ||
|
||
public var debugDescription: String { | ||
"\(Self.self)(requestID: \(self.requestID), traceID: \(self.traceID), invokedFunctionARN: \(self.invokedFunctionARN), cognitoIdentity: \(self.cognitoIdentity ?? "nil"), clientContext: \(self.clientContext ?? "nil"), deadline: \(self.deadline))" | ||
} | ||
|
||
/// This interface is not part of the public API and must not be used by adopters. This API is not part of semver versioning. | ||
/// The timeout is expressed relative to now | ||
package static func __forTestsOnly( | ||
requestID: String, | ||
traceID: String, | ||
invokedFunctionARN: String, | ||
timeout: DispatchTimeInterval, | ||
timeout: Duration, | ||
logger: Logger | ||
) -> LambdaContext { | ||
LambdaContext( | ||
requestID: requestID, | ||
traceID: traceID, | ||
invokedFunctionARN: invokedFunctionARN, | ||
deadline: .now() + timeout, | ||
deadline: Duration.millisSinceEpoch + timeout, | ||
logger: logger | ||
) | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.