Skip to content

[stable/21.x] [API notes] Allow SwiftConformsTo on Typedefs #11078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2025

Conversation

AnthonyLatsis
Copy link

@AnthonyLatsis AnthonyLatsis commented Jul 29, 2025

Cherry-picks #11050 (the original PR). That PR has 3 commits. This one has 2.

The first two from the original PR were upstreamed in llvm#149951, so I cherry-picked that instead (that’s one commit because the PR was squashed). The second commit here is a cherry-pick of the third from the original.

…9951)

Forward declarations can still have useful API notes applied to them.
When the use of the tag is not a definition, apply the API notes
immediately.

Fixes rdar://156288588.

(cherry picked from commit 8c26858)
SwiftConformsTo specifies an additional conformance that should be
applied on import. Allow this on typedefs, because those can be imported
as wrapper types.

Clang side of rdar://156290361

(cherry picked from commit 01b28c4)
@AnthonyLatsis
Copy link
Author

Verified locally that this fixes Interop/Cxx/foreign-reference/incomplete.swift.

@AnthonyLatsis AnthonyLatsis merged commit 92d1fb7 into stable/21.x Jul 29, 2025
@AnthonyLatsis AnthonyLatsis deleted the jepa-stable branch July 29, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants