Skip to content

Promote Windows image attachments to API. #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2025
Merged

Promote Windows image attachments to API. #1333

merged 1 commit into from
Oct 9, 2025

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Sep 23, 2025 •
edited
Loading

Remove @_spi and adjust documentation as needed now that ST-0015 has been approved.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan grynspan added this to the Swift 6.x (main) milestone Sep 23, 2025
@grynspan grynspan self-assigned this Sep 23, 2025
@grynspan grynspan added documentation 📚 Improvements or additions to documentation windows 🪟 Windows support public-api Affects public API attachments/activities 🖇️ Work related to attachments and/or activities cross-import-overlays 🍰 Cross-import overlays (Foundation, Core Graphics, etc.) image-attachments 📸 Work related to image attachments labels Sep 23, 2025
@grynspan
Copy link
Contributor Author

Blocked on swiftlang/swift#84466.

@grynspan grynspan marked this pull request as ready for review October 6, 2025 15:48
@grynspan
Promote Windows image attachments to API.
5c4bab7 
Remove `@_spi` and adjust documentation as needed. Pending approval of
[ST-0015](https://forums.swift.org/t/st-0015-image-attachments-in-swift-testing-windows/82241).
@grynspan grynspan force-pushed the jgrynspan/promote-windows-image-attachments-to-api branch from e5f0002 to 5c4bab7 Compare October 9, 2025 18:52
@grynspan grynspan merged commit 08f39d6 into main Oct 9, 2025
24 checks passed
@grynspan grynspan deleted the jgrynspan/promote-windows-image-attachments-to-api branch October 9, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

@jerryjrchen jerryjrchen Awaiting requested review from jerryjrchen jerryjrchen is a code owner

Assignees

@grynspan grynspan

Labels

attachments/activities 🖇️ Work related to attachments and/or activities cross-import-overlays 🍰 Cross-import overlays (Foundation, Core Graphics, etc.) documentation 📚 Improvements or additions to documentation image-attachments 📸 Work related to image attachments public-api Affects public API windows 🪟 Windows support

Projects

None yet

Milestone

Swift 6.x (main)

Development

Successfully merging this pull request may close these issues.

2 participants

@grynspan @stmontgomery