[DNM] Rebranch testing

[AnthonyLatsis]

No description provided.

[aschwaighofer]

LGTM

Thank you

[bnbarham]

@aschwaighofer do we actually care about checking for captures(none) and nuw? I mostly ask because it would be nice if we could avoid main conflicts here, which we could do if we used {{.*}} rather than the actual checks.

[adrian-prantl]

LGTM!

[AnthonyLatsis]

@swift-ci please build toolchain Ubuntu 24.04

[Xazax-hun]

swiftlang/llvm-project#10909

@swift-ci please smoke test macOS

[AnthonyLatsis]

swiftlang/llvm-project#11120

@swift-ci please test Windows

[AnthonyLatsis]

@swift-ci please test Windows

[AnthonyLatsis]

@compnerd Any ideas on how to address this?

swiftAPIDigester.lib(ModuleAnalyzerNodes.cpp.obj) : error LNK2019: unresolved external symbol "__declspec(dllimport) public: static bool __cdecl clang::SwiftPrivateAttr::classof(class clang::Attr const *)" (__imp_?classof@SwiftPrivateAttr@clang@@SA_NPEBVAttr@2@@Z) referenced in function "public: bool __cdecl swift::ide::api::SDKContext::shouldIgnore(class swift::Decl *,class swift::Decl const *)const " (?shouldIgnore@SDKContext@api@ide@swift@@QEBA_NPEAVDecl@4@PEBV54@@Z)

class CLANG_ABI SwiftPrivateAttr : public InheritableAttr {
public:
  // Factory methods
  static SwiftPrivateAttr *CreateImplicit(ASTContext &Ctx, const AttributeCommonInfo &CommonInfo);
  static SwiftPrivateAttr *Create(ASTContext &Ctx, const AttributeCommonInfo &CommonInfo);
  static SwiftPrivateAttr *CreateImplicit(ASTContext &Ctx, SourceRange Range = {});
  static SwiftPrivateAttr *Create(ASTContext &Ctx, SourceRange Range = {});

  // Constructors
  SwiftPrivateAttr(ASTContext &Ctx, const AttributeCommonInfo &CommonInfo
             );

  SwiftPrivateAttr *clone(ASTContext &C) const;
  void printPretty(raw_ostream &OS,
                   const PrintingPolicy &Policy) const;
  const char *getSpelling() const;


  static bool classof(const Attr *A) { return A->getKind() == attr::SwiftPrivate; }
};

https://ci-external.swift.org/view/Pull%20Request/job/swift-PR-windows/43993

---

I tried a different attribute here, and this is not specific to SwiftPrivateAttr.

[compnerd]

The __declspec(dllimport) seems to be the key piece to focus on. I don't think that we are yet linking dynamically against the Swift compiler. I think that you likely have an issue with macros making it think that you are importing a symbol from a DLL rather than statically linking. I would investigate the output of -E -dD and see why it it expanding to __declspec(dllimport) rather than /**/.

[AnthonyLatsis]

swiftlang/llvm-project#11127

@swift-ci please test Windows