Skip to content

[demangling] make printGenericSignature virtual #83375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

charles-zablit
Copy link
Contributor

Make printGenericSignature a virtual method, allowing it to be overridden in lldb's TrackingNodePrinter.

This is a dependency of swiftlang/llvm-project#11068.

@charles-zablit charles-zablit self-assigned this Jul 28, 2025
@charles-zablit charles-zablit requested a review from rjmccall as a code owner July 28, 2025 16:21
@charles-zablit
Copy link
Contributor Author

@swift-ci please test

@charles-zablit
Copy link
Contributor Author

@swift-ci please test macOS

@charles-zablit charles-zablit added the demangling Area → compiler: The `libswiftDemangling` library label Jul 29, 2025
@Michael137
Copy link
Contributor

Seems fine. Lets merge once the dependent PRs get approved

@charles-zablit
Copy link
Contributor Author

@swift-ci please test macOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
demangling Area → compiler: The `libswiftDemangling` library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants