[rebranch] Fix WebAssembly test failures #84342
Closed
+8
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
requested review from
AnthonyLatsis and
rjmccall
as code owners
|
@swift-ci please smoke test Linux |
MaxDesiatov
approved these changes
Sep 17, 2025
`.swift_ast` section is now recognized as a "metadata" section by LLVM's object emission. On WebAssembly, metadata symbols must not appear in the object file symbol table. Therefore, change the linkage of the `@__Swift_AST` global from InternalLinkage to PrivateLinkage to avoid exposing the symbol. swiftlang/llvm-project@555eaef
Follow-up fix for 17fc00f
kateinoigakukun
force-pushed
the
yt/rebranch-wasm-tests
branch
from
7959e39 to
69ca06b
Compare
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.