[Backtracing] Add check for theoretical environment overflow issue. #84344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pretty sure this can't ever trigger because of operating system limits on the size of environment strings, but since overflow tests are cheap, there seems no reason not to add one. rdar://160307933
|
@swift-ci Please smoke test |
mikeash
reviewed
Sep 17, 2025
| size_t totalLen = nameLen + 1 + valueLen + 1; | ||
| size_t totalLen; | ||
|
|
||
| if (__builtin_add_overflow(nameLen + 1, valueLen + 1, &totalLen)) { |
There was a problem hiding this comment.
Perhaps a bit silly, but should we also overflow check the +2 (+1+1)?
There was a problem hiding this comment.
I don't believe we need to do that. I don't think std::strlen() returning SIZE_MAX is something we ever need worry about.
mikeash
approved these changes
Sep 17, 2025
|
Linux had a failure in SwiftPM's tests, unrelated to this PR. |
|
@swift-ci Please smoke test Linux platform |
1 similar comment
|
@swift-ci Please smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty sure this can't ever trigger because of operating system limits on the size of environment strings, but since overflow tests are cheap, there seems no reason not to add one.
rdar://160307933