Embedded swift restrictions #84374
Merged
Embedded swift restrictions #84374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
requested review from
a team,
hborla,
xedin,
slavapestov,
artemcm,
tshortli and
jckarter
as code owners
…propriate group Embedded Swift must defer some of the diagnostics about its restrictions to late in the optimization pipeline, because some source-level constructs (such as metatypes) are allowed in specific cases that cannot be diagnosed in the type checker. Put these diagnostics into the same EmbeddedRestrictions diagnostic group as the type checker diagnostics, because that's the central point at which we can direct folks to more information about the restrictions in Embedded Swift. Addresses rdar://119383905.
…ecker Move the diagnostic about non-final generic methods in classes up to the type checker, so that it is available to `-Wwarning EmbeddedRestrictions` and earlier in the pipeline. The SIL version of this is still available as a backstop. Yet another part of rdar://133874555.
Generic methods declared in protocols (and extensions thereof) cannot be used on existential values, because there is no way to specialize them for all potential types. Diagnose such cases in Embedded Swift mode and via `-Wwarning EmbeddedRestrictions`. This adds a bunch more warnings to the standard library that we'll need to clean up, probably by `#if`'ing more code out. Part of rdar://119383905.
… methods to a warning The existing SIL-level diagnostic for this check only triggers when the type is actually used, while the type-checker version is more eager. Stage in the stricter check as a warning and we'll clamp down on things later.
Embedded Swift doesn't have protocol conformance metadata, so it cannot handle dynamic casts to existentials (nor should it). Another part of rdar://119383905.
DougGregor
force-pushed
the
embedded-swift-restrictions
branch
from
5ce4274 to
11976c5
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement diagnostics in the type checker for more of the Embedded Swift language restrictions in the type checker. They are all introduced as warnings in the same diagnostic group (
EmbeddedRestrictions), which also documents the restrictions. Take existing diagnostics in SIL and put them in the same diagnostic group. Diagnostics introduced include:This is tracked by rdar://119383905