Test/boost #44
Merged
Test/boost #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts boost tests to handle platform-specific differences between iOS and Android, primarily addressing the fact that Android shows an additional boost transaction item while iOS does not.
Key changes:
- Added platform-specific conditional logic using
driver.isAndroidto handle different transaction list behaviors - Updated element selectors from generic strings to more specific IDs (e.g.,
'later_button'→'BackupIntroViewCancel') - Modified text matching strategy to use
'contains'instead of exact matching for better test stability
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/specs/boost.e2e.ts | Added conditional logic to handle platform differences in boost transaction display, updated text matching strategy |
| test/helpers/actions.ts | Updated element IDs to more specific names, removed iOS platform restriction from timed sheet helpers, and added triggerTimedSheet parameter usage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Nov 10, 2025
piotr-iohk
force-pushed
the
test/boost
branch
from
28cd114 to
a9d96c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjustments for boost tests for iOS/Android.
Related:
synonymdev/bitkit-ios#213
synonymdev/bitkit-android#462