fix: Dissmiss keyboard in TextEditor #217
Merged
+28
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes keyboard dismissal behavior in TextEditor components by implementing a custom view modifier that dismisses the keyboard when the user presses the return key. The solution detects newline characters and automatically removes them while dismissing the keyboard.
Key changes:
- Created a reusable
dismissKeyboardOnReturnview modifier - Applied the modifier to two
TextEditorinstances with accessibility improvements - Replaced manual
.onSubmithandling with the new standardized approach
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| TextEditor+DismissOnReturn.swift | New extension file containing the keyboard dismissal modifier implementation |
| SendEnterManuallyView.swift | Applied the new modifier and added accessibility support |
| ReceiveEdit.swift | Replaced .onSubmit with the new modifier and added accessibility support |
jvsena42
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix to hide keyboard on submit in TextEditor, see: #216.
Linked Issues/Tasks
Closes #216.
Screenshot / Video
Simulator.Screen.Recording.-.iPhone.17.-.2025-11-11.at.18.49.11.mov